Skip to content

[ROCm][CI] Minor missing import patch#38951

Merged
khluu merged 1 commit intovllm-project:mainfrom
ROCm:akaratza_fix_patch
Apr 3, 2026
Merged

[ROCm][CI] Minor missing import patch#38951
khluu merged 1 commit intovllm-project:mainfrom
ROCm:akaratza_fix_patch

Conversation

@AndreasKaratzas
Copy link
Copy Markdown
Collaborator

Fixes minor import bug.

cc @kenroche

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@AndreasKaratzas AndreasKaratzas marked this pull request as ready for review April 3, 2026 22:31
@AndreasKaratzas AndreasKaratzas added ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm and removed ready ONLY add when PR is ready to merge/full CI is needed labels Apr 3, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Apr 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an import statement for the sys module within the pytest_unconfigure function in the Dockerfile for ROCm. I have no further feedback to provide.

@khluu khluu enabled auto-merge (squash) April 3, 2026 22:59
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 3, 2026
@khluu khluu merged commit 4b506ff into vllm-project:main Apr 3, 2026
14 of 16 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Apr 3, 2026
@AndreasKaratzas AndreasKaratzas deleted the akaratza_fix_patch branch April 3, 2026 23:02
@mergify mergify Bot added the ci/build label Apr 4, 2026
HenryTangDev pushed a commit to HenryTangMain/vllm that referenced this pull request Apr 6, 2026
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
puririshi98 pushed a commit to puririshi98/vllm that referenced this pull request Apr 7, 2026
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Rishi Puri <riship@nvidia.com>
mtparet pushed a commit to blackfuel-ai/vllm that referenced this pull request Apr 9, 2026
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants